update by ded7g · Pull Request #2513 · mate-academy/jv-oop

ded7g · 2026-01-14T09:57:38Z

No description provided.

mateacademy-ai-mentor

Review Summary

Great job on setting up the abstract class and the inheritance structure! However, a few changes are needed before this can be approved.

The main issue is in MainApp.java, where the program will crash with an ArrayIndexOutOfBoundsException. The machines array is initialized with a size of 2, but you are adding three machines to it. Please make sure the array is large enough to hold all the machine instances.

Additionally, please address the following:

There is a typo in the Buldozer class name; it should be Bulldozer as required by the task.
The output messages in the doWork() and stopWork() methods for all machine classes are not informative enough [CHECKLIST ITEM #2]. They should clearly state that the machine has started or stopped its work, for example, Truck started its work.

Fixing these points will get your solution ready for approval. Keep up the great work!

✨ Please rate this review in the Platform's notification center¹. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button² in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag³.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

mateacademy-ai-mentor · 2026-01-14T09:59:13Z

src/main/java/core/basesyntax/Excavator.java

+public class Excavator extends Machine {
+    @Override
+    public void doWork() {
+        System.out.println("Excavator doWork");


This violates checklist item #2: 'Write informative messages in methods.' The current message is a bit too literal. A more descriptive message, such as 'Excavator started its work,' would better align with the requirements.

mateacademy-ai-mentor · 2026-01-14T09:59:13Z

src/main/java/core/basesyntax/Excavator.java

+
+    @Override
+    public void stopWork() {
+        System.out.println("Excavator stopWork");


This violates checklist item #2: 'Write informative messages in methods.' Similar to the doWork() method, this message could be more informative. For example, 'Excavator stopped its work.' would be more descriptive.

mateacademy-ai-mentor · 2026-01-14T09:59:13Z

src/main/java/core/basesyntax/MainApp.java

+        Machine[] machines = new Machine[2];
+        machines[0] = new Buldozer();
+        machines[1] = new Truck();
+        machines[2] = new Excavator();


You have initialized an array with a size of 2, but you are attempting to add three elements to it. This will cause an ArrayIndexOutOfBoundsException when the program tries to execute line 8, as the valid indices are 0 and 1. The array size should be large enough to hold all the machines.

mateacademy-ai-mentor · 2026-01-14T09:59:13Z

src/main/java/core/basesyntax/Buldozer.java

@@ -0,0 +1,13 @@
+package core.basesyntax;
+
+public class Buldozer extends Machine {


There's a typo in the class name. According to the task description, it should be Bulldozer.

mateacademy-ai-mentor · 2026-01-14T09:59:13Z

src/main/java/core/basesyntax/Buldozer.java

+public class Buldozer extends Machine {
+    @Override
+    public void doWork() {
+        System.out.println("Buldozer doWork");


This violates checklist item #2: 'Write informative messages in methods'. The message should be more descriptive, for example: "Bulldozer started its work".

mateacademy-ai-mentor · 2026-01-14T09:59:13Z

src/main/java/core/basesyntax/Buldozer.java

+
+    @Override
+    public void stopWork() {
+        System.out.println("Buldozer stopWork");


This violates checklist item #2: 'Write informative messages in methods'. The message should be more descriptive, for example: "Bulldozer stopped working".

mateacademy-ai-mentor · 2026-01-14T09:59:13Z

src/main/java/core/basesyntax/Truck.java

+public class Truck extends Machine {
+    @Override
+    public void doWork() {
+        System.out.println("Truck doWork");


This violates checklist item #2: 'Write informative messages in methods'. The message should be more descriptive, like 'Truck started its work', to clearly indicate the action being performed.

mateacademy-ai-mentor · 2026-01-14T09:59:13Z

src/main/java/core/basesyntax/Truck.java

+
+    @Override
+    public void stopWork() {
+        System.out.println("Truck stopWork");


This violates checklist item #2: 'Write informative messages in methods'. Similar to the doWork method, this message should be more informative, for example: 'Truck stopped working'.

mateacademy-ai-mentor

Sorry, the pull request review was unsuccessful for the following reasons:

Warning

No changes were made in the pull request since the last review. Please make sure that you have added files to the pull request and committed the changes.
_{[CODE: NCM]}

If the issue is within your control, please address it.
The next review attempt will automatically launch in about 1 hour.
If you believe this is an error or need assistance, please contact the support team.

mateacademy-ai-mentor

Review Summary

Excellent progress on this task! You've successfully fixed the previous issues with the array size and the output messages. However, changes are needed because a core requirement is not yet met. The class for the bulldozer is consistently misspelled as Buldozer instead of Bulldozer. To fix this, please: 1. Rename the file Buldozer.java to Bulldozer.java. 2. Update the class declaration inside the file to public class Bulldozer. 3. Correct the object creation in MainApp.java to new Bulldozer(). 4. Update the strings in the doWork() and stopWork() methods to use "Bulldozer". Once you make this correction, your solution will be ready for approval. You're very close!

✨ Please rate this review in the Platform's notification center¹. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button² in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag³.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

mateacademy-ai-mentor · 2026-01-14T11:21:28Z

src/main/java/core/basesyntax/Buldozer.java

@@ -0,0 +1,13 @@
+package core.basesyntax;
+
+public class Buldozer extends Machine {


The class name is still misspelled. According to the task requirements, it should be Bulldozer. Please also update the filename and the output messages on lines 6 and 11 to reflect this change.

mateacademy-ai-mentor · 2026-01-14T11:21:28Z

src/main/java/core/basesyntax/MainApp.java

 public class MainApp {
+    public static void main(String[] args) {
+        Machine[] machines = new Machine[3];
+        machines[0] = new Buldozer();


The class name Buldozer has a typo. According to the task requirements, it should be Bulldozer.

mateacademy-ai-mentor

Review Summary

Excellent work on this submission! You've successfully fixed the critical Bulldozer spelling issue, and the program now works perfectly according to the requirements.

I am approving this solution to help you progress, but please note a minor code style issue for future reference. In src/main/java/core/basesyntax/Machine.java, there are a couple of redundant empty lines after the class declaration and between method declarations. It's a good practice to keep the code clean and avoid unnecessary blank lines [CHECKLIST ITEM #1].

Overall, this is a very solid implementation. Keep up the great work!

✨ Please rate this review in the Platform's notification center¹. I will be grateful for your feedback! ✨

Rate AI review example ↩

mateacademy-ai-mentor · 2026-01-14T13:07:58Z

src/main/java/core/basesyntax/Machine.java

+package core.basesyntax;
+
+public abstract class Machine {
+


This empty line after the class declaration is redundant. This violates checklist item #1: 'Please don't add redundant empty lines to your code.'

mateacademy-ai-mentor · 2026-01-14T13:07:58Z

src/main/java/core/basesyntax/Machine.java

+public abstract class Machine {
+
+    public abstract void doWork();
+


This empty line between the method declarations is also redundant. This violates checklist item #1: 'Please don't add redundant empty lines to your code.'

update

19074cd

mateacademy-ai-mentor suggested changes Jan 14, 2026

View reviewed changes

update

714d5eb

ded7g requested a review from mateacademy-ai-mentor January 14, 2026 10:03

mateacademy-ai-mentor reviewed Jan 14, 2026

View reviewed changes

ded7g requested a review from mateacademy-ai-mentor January 14, 2026 10:05

mateacademy-ai-mentor suggested changes Jan 14, 2026

View reviewed changes

update

a964a92

ded7g requested a review from mateacademy-ai-mentor January 14, 2026 13:06

mateacademy-ai-mentor approved these changes Jan 14, 2026

View reviewed changes

		@@ -0,0 +1,13 @@
		package core.basesyntax;

		public class Buldozer extends Machine {

		public abstract class Machine {

		public abstract void doWork();

Conversation

ded7g commented Jan 14, 2026

Uh oh!

mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

Review Summary

Footnotes

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

Uh oh!

mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

Review Summary

Footnotes

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

Review Summary

Footnotes

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants